tracer/x-editable
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

option emptyclass

Browse Source
This commit is contained in:
vitalets 2013-01-16 23:32:57 +04:00
parent 0a8561cabd
commit 18267a8d07
4 changed files with 78 additions and 30 deletions

1
CHANGELOG.txt

@ -4,6 +4,7 @@ X-editable changelog
Version 1.4.1 wip
----------------------------
[enh] new option `emptyclass` to set css class when element is empty (vitalets)
[enh #59] select2 input (vitalets)
[enh #17] typeahead input (vitalets)
[enh] select: support of OPTGROUP via `children` key in source (vitalets)

39
src/element/editable-element.js

@ -127,7 +127,7 @@ Makes editable any HTML element on the page. Applied as jQuery method.
enable: function() {
this.options.disabled = false;
this.$element.removeClass('editable-disabled');
this.handleEmpty();
this.handleEmpty(this.isEmpty);
if(this.options.toggle !== 'manual') {
if(this.$element.attr('tabindex') === '-1') {
this.$element.removeAttr('tabindex');
@ -143,7 +143,7 @@ Makes editable any HTML element on the page. Applied as jQuery method.
this.options.disabled = true;
this.hide();
this.$element.addClass('editable-disabled');
this.handleEmpty();
this.handleEmpty(this.isEmpty);
//do not stop focus on this element
this.$element.attr('tabindex', -1);
},
@ -204,27 +204,33 @@ Makes editable any HTML element on the page. Applied as jQuery method.
},
/*
* set emptytext if element is empty (reverse: remove emptytext if needed)
* set emptytext if element is empty
*/
handleEmpty: function () {
handleEmpty: function (isEmpty) {
//do not handle empty if we do not display anything
if(this.options.display === false) {
return;
}
var emptyClass = 'editable-empty';
this.isEmpty = isEmpty !== undefined ? isEmpty : $.trim(this.$element.text()) === '';
//emptytext shown only for enabled
if(!this.options.disabled) {
if ($.trim(this.$element.text()) === '') {
this.$element.addClass(emptyClass).text(this.options.emptytext);
} else {
this.$element.removeClass(emptyClass);
if (this.isEmpty) {
this.$element.text(this.options.emptytext);
if(this.options.emptyclass) {
this.$element.addClass(this.options.emptyclass);
}
} else if(this.options.emptyclass) {
this.$element.removeClass(this.options.emptyclass);
}
} else {
//below required if element disable property was changed
if(this.$element.hasClass(emptyClass)) {
if(this.isEmpty) {
this.$element.empty();
this.$element.removeClass(emptyClass);
if(this.options.emptyclass) {
this.$element.removeClass(this.options.emptyclass);
}
}
}
},
@ -593,7 +599,16 @@ Makes editable any HTML element on the page. Applied as jQuery method.
}
}
**/
display: null
display: null,
/**
Css class applied when editable text is empty.
@property emptyclass
@type string
@default editable-empty
@since 1.4.1
**/
emptyclass: 'editable-empty'
};
}(window.jQuery));

45
test/unit/common.js

@ -546,4 +546,49 @@
ok(p.hasClass('editable-inline'), 'has inline class');
});
test("emptytext, emptyclass", function () {
var emptytext = 'empty!',
emptyclass = 'abc',
e = $('<a href="#" id="a"> </a>').appendTo('#qunit-fixture').editable({
emptytext: emptytext,
emptyclass: emptyclass,
send: 'never'
});
equal(e.text(), emptytext, 'emptytext shown on init');
ok(e.hasClass(emptyclass), 'emptyclass added');
e.click();
var p = tip(e);
equal(p.find('input[type="text"]').val(), '', 'input val is empty string');
// p.find('.editable-cancel').click();
//set non-empty value
p.find('input[type="text"]').val('abc');
p.find('form').submit();
ok(!p.is(':visible'), 'popover was removed');
ok(e.text() != emptytext, 'emptytext not shown');
ok(!e.hasClass(emptyclass), 'emptyclass removed');
e.click();
p = tip(e);
p.find('input[type="text"]').val('');
p.find('form').submit();
ok(!p.is(':visible'), 'popover was removed');
equal(e.text(), emptytext, 'emptytext shown');
ok(e.hasClass(emptyclass), 'emptyclass added');
e.editable('disable');
equal(e.text(), '', 'emptytext removed');
ok(!e.hasClass(emptyclass), 'emptyclass removed');
e.editable('enable');
e.editable('enable');
equal(e.text(), emptytext, 'emptytext shown');
ok(e.hasClass(emptyclass), 'emptyclass added');
});
}(jQuery));

13
test/unit/text.js

@ -7,19 +7,6 @@ $(function () {
}
});
test("if element originally empty: emptytext should be shown and input should contain ''", function () {
var emptytext = 'empty!',
e = $('<a href="#" id="a"> </a>').appendTo('#qunit-fixture').editable({emptytext: emptytext});
equal(e.text(), emptytext, 'emptytext shown on init');
e.click();
var p = tip(e);
equal(p.find('input[type="text"]').val(), '', 'input val is empty string')
p.find('.editable-cancel').click();
ok(!p.is(':visible'), 'popover was removed')
})
test("option 'placeholder'", function () {
var e = $('<a href="#" id="a" data-placeholder="abc"> </a>').appendTo('#qunit-fixture').editable();