From 28e1f68cd3692f24c78b0cf20903cf6d5c8846e5 Mon Sep 17 00:00:00 2001
From: vitalets <vitalets@yandex-team.ru>
Date: Fri, 4 Oct 2013 21:33:39 +0400
Subject: [PATCH] fix processing `true` returned by validate method, fix #155
---
src/editable-form/editable-form.js | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/editable-form/editable-form.js b/src/editable-form/editable-form.js
index c577812..96b6b0c 100644
--- a/src/editable-form/editable-form.js
+++ b/src/editable-form/editable-form.js
@@ -181,7 +181,7 @@ Editableform is linked with one of input types, e.g. 'text', 'select' etc.
} else {
//convert newline to <br> for more pretty error display
if(msg) {
- lines = msg.split("\n");
+ lines = (''+msg).split('\n');
for (var i = 0; i < lines.length; i++) {
lines[i] = $('<div>').text(lines[i]).html();
}
@@ -196,11 +196,12 @@ Editableform is linked with one of input types, e.g. 'text', 'select' etc.
e.stopPropagation();
e.preventDefault();
- var error,
- newValue = this.input.input2value(); //get new value from input
+ //get new value from input
+ var newValue = this.input.input2value();
- //validation
- if (error = this.validate(newValue)) {
+ // validation: if validate returns truthy value - means error
+ var error = this.validate(newValue)
+ if (error) {
this.error(error);
this.showForm();
return;